jihoonson commented on a change in pull request #9545: SQL support for joins on
subqueries.
URL: https://github.com/apache/druid/pull/9545#discussion_r395889456
##########
File path:
sql/src/test/java/org/apache/druid/sql/calcite/CalciteParameterQueryTest.java
##########
@@ -602,14 +602,13 @@ public void testWrongTypeParameter() throws Exception
and(
bound("l1", "3", null, true, false, null,
StringComparators.NUMERIC),
selector("f1", useDefault ? "0.0" : null, null)
-
)
)
.aggregators(aggregators(new CountAggregatorFactory("a0")))
.context(TIMESERIES_CONTEXT_DEFAULT)
.build()
) : ImmutableList.of(),
- useDefault ? ImmutableList.of() : ImmutableList.of(new Object[]{0L}),
+ ImmutableList.of(),
Review comment:
This doesn't seem right.. I guess it should be always 0.
Based on the expected results before this PR, it seems that a timeseries
query was issued when `useDefault = true` which returns an empty result. When
`useDefault = false`, no query was issued so probably the query computation was
done by Calcite.
So, I guess there are two potential issues here. One is the timeseries query
returning an empty result and another is Calcite returning an empty result
which used to return a valid result. We may want to fix the Calcite issue in
this PR. The timeseries issue seems a bug, but since it's not introduced in
this PR and we are about to cut the branch for 0.18, I'm ok with merging this
PR and backporting the bug fix later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
