gianm commented on a change in pull request #9545: SQL support for joins on
subqueries.
URL: https://github.com/apache/druid/pull/9545#discussion_r395919417
##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidRel.java
##########
@@ -71,17 +71,14 @@ public boolean isValidDruidQuery()
* Convert this DruidRel to a DruidQuery. This may be an expensive
operation. For example, DruidSemiJoin needs to
* execute the right-hand side query in order to complete this method.
*
- * This method may return null if it knows that this rel will yield an empty
result set.
+ * This method may not return null.
Review comment:
Changed it to "This method must not return null."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
