maytasm3 commented on a change in pull request #9560: Instructions to run 
integration tests against quickstart
URL: https://github.com/apache/druid/pull/9560#discussion_r398089064
 
 

 ##########
 File path: integration-tests/README.md
 ##########
 @@ -66,7 +66,40 @@ Integration tests can also be run with either Java 8 or 
Java 11 by adding -Djvm.
 can either be 8 or 11.
 
 Druid's configuration (using Docker) can be overrided by providing 
-Doverride.config.path=<PATH_TO_FILE>. 
-The file must contain one property per line, the key must start with druid_ 
and the format should be snake case. 
+The file must contain one property per line, the key must start with `druid_` 
and the format should be snake case. 
+
+Running Tests Using A Quickstart Cluster
+-------------------
+
+When writing integration tests, it can be helpful to test against a quickstart
+cluster so that you can set up remote debugging with in your developer
+environment. This section walks you through setting up the integration tests
+so that it can run against a quickstart cluster running on your development
+machine.
+
+Note that not all features run by default on a quickstart cluster, so it may
 
 Review comment:
   I feel the term "feature" might be a little misleading. Some of the setup on 
the docker cluster are just pre-inserted data into the metadata store or 
certain files place at certain locations. The feature itself like pulling 
segments from pathSpec in metadatastore is always there. I think as we add more 
and more IT and/or setup scripts, it will also be hard to knows which can work 
out of the box on quickstart vs. which can only work on docker cluster. I think 
it might help if we can list out which groups can work out of the box on 
quickstart vs. which can only work on docker cluster in the README. In the file 
with the group definition (TestNGGroup) we can then list out special setup 
needed (if needed) for those groups. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to