ccaominh commented on a change in pull request #9560: Instructions to run 
integration tests against quickstart
URL: https://github.com/apache/druid/pull/9560#discussion_r398202520
 
 

 ##########
 File path: 
integration-tests/src/test/java/org/apache/druid/tests/TestNGGroup.java
 ##########
 @@ -33,29 +33,57 @@
   // This group can only be run individually using -Dgroups=query since it 
requires specific test data setup.
   public static final String QUERY = "query";
   public static final String REALTIME_INDEX = "realtime-index";
-  // This group can only be run individually using -Dgroups=security since it 
requires specific test data setup.
+
+  /**
+   * This group can only be run individually using -Dgroups=security since it 
requires specific test data setup.
+   */
   public static final String SECURITY = "security";
-  // This group is not part of CI. To run this group, s3 configs/credentials 
for your s3 must be provided in a file.
-  // The path of the file must then be pass to mvn with 
-Doverride.config.path=<PATH_TO_FILE>
-  // See integration-tests/docker/environment-configs/override-examples/s3 for 
env vars to provide.
+
+  /**
+   * This group is not part of CI. To run this group, s3 configs/credentials 
for your s3 must be provided in a file.
+   * The path of the file must then be pass to mvn with 
-Doverride.config.path=<PATH_TO_FILE>
+   * See integration-tests/docker/environment-configs/override-examples/s3 for 
env vars to provide.
+   */
   public static final String S3_DEEP_STORAGE = "s3-deep-storage";
-  // This group is not part of CI. To run this group, gcs configs/credentials 
for your gcs must be provided in a file.
-  // The path of the file must then be pass to mvn with 
-Doverride.config.path=<PATH_TO_FILE>
-  // See integration-tests/docker/environment-configs/override-examples/gcs 
for env vars to provide.
-  // The path to the folder that contains your GOOGLE_APPLICATION_CREDENTIALS 
file must also be pass
-  // to mvn with -Dresource.file.dir.path=<PATH_TO_FOLDER>
+
+  /**
+   * This group is not part of CI. To run this group, gcs configs/credentials 
for your gcs must be provided in a file.
+   * The path of the file must then be pass to mvn with 
-Doverride.config.path=<PATH_TO_FILE>
+   * See integration-tests/docker/environment-configs/override-examples/gcs 
for env vars to provide.
+   * The path to the folder that contains your GOOGLE_APPLICATION_CREDENTIALS 
file must also be pass
+   * to mvn with -Dresource.file.dir.path=<PATH_TO_FOLDER>
+   */
   public static final String GCS_DEEP_STORAGE = "gcs-deep-storage";
-  // This group is not part of CI. To run this group, azure 
configs/credentials for your azure must be provided in a file.
-  // The path of the file must then be pass to mvn with 
-Doverride.config.path=<PATH_TO_FILE>
-  // See integration-tests/docker/environment-configs/override-examples/azures 
for env vars to provide.
+
+  /**
+   * This group is not part of CI. To run this group, azure 
configs/credentials for your azure must be provided in a file.
+   * The path of the file must then be pass to mvn with 
-Doverride.config.path=<PATH_TO_FILE>
+   * See integration-tests/docker/environment-configs/override-examples/azures 
for env vars to provide.
+   */
   public static final String AZURE_DEEP_STORAGE = "azure-deep-storage";
-  // This group is not part of CI. To run this group, hadoop configs must be 
provided in a file. The path of the file
-  // must then be pass to mvn with -Doverride.config.path=<PATH_TO_FILE>
-  // See integration-tests/docker/environment-configs/override-examples/hdfs 
for env vars to provide.
-  // Additionally, hadoop docker must be started by passing 
-Dstart.hadoop.docker=true to mvn.
+
+  /**
+   * This group is not part of CI. To run this group, hadoop configs must be 
provided in a file. The path of the file
+   * must then be pass to mvn with -Doverride.config.path=<PATH_TO_FILE>
+   * See integration-tests/docker/environment-configs/override-examples/hdfs 
for env vars to provide.
+   * Additionally, hadoop docker must be started by passing 
-Dstart.hadoop.docker=true to mvn.
+   */
   public static final String HDFS_DEEP_STORAGE = "hdfs-deep-storage";
-  // This group is not part of CI. To run this group, s3 configs/credentials 
for your s3 must be provided in a file.
-  // The path of the file must then be pass to mvn with 
-Doverride.config.path=<PATH_TO_FILE>
-  // See integration-tests/docker/environment-configs/override-examples/s3 for 
env vars to provide.
+
+  /**
+   * This group is not part of CI. To run this group, s3 configs/credentials 
for your s3 must be provided in a file.
+   * The path of the file must then be pass to mvn with 
-Doverride.config.path=<PATH_TO_FILE>
+   * See integration-tests/docker/environment-configs/override-examples/s3 for 
env vars to provide.
+   */
   public static final String S3_INGESTION = "s3-ingestion";
+
+  /**
+   * This group os not part of CI explicitly. It allows you to run all the 
tests that have been tested with
 
 Review comment:
   If you push another commit, there's a small typo here: group os -> group is

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to