himanshug commented on issue #9564: Framework for aggregate testing; Example tests with LongSumAggregatorFactory URL: https://github.com/apache/druid/pull/9564#issuecomment-604735785 > Would you tell me more about this I was referring to all the extra code it took to test LongSum aggregator in this PR. :) > Thanks for pointing it out. My original intention was to add a low-level framework for aggregator testing without using the query framework (because it's high-level!), but I admit they are kind of similar. Let me check if they can be merged. `AggregationTestHelper` lets you do more of "pseudo integration testing" . This type of testing is specially useful for complex aggregators . For example ensuring the intermediate sketch data representations are handled properly in various combinations. However, I think it is missing the data generation part, if we aid it with data generation then it can test all the different scenarios an aggregator implementation gets exercised inside of a Druid cluster. It would be nice if tests like `DoubleMeanAggregationTest` could use the generic data generation framework than to create their own limited dummy data sets and that would enable covering even more code paths. Further low level UTs are nice to have to flush out other corners that above high level tests can't exercise.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
