Fokko commented on a change in pull request #9579: Add Apache Ranger Authorization URL: https://github.com/apache/druid/pull/9579#discussion_r399772685
########## File path: extensions-core/druid-ranger-security/src/main/java/org/apache/druid/security/ranger/authorizer/RangerAuthorizer.java ########## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.security.ranger.authorizer; + +import com.fasterxml.jackson.annotation.JsonCreator; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonTypeName; +import org.apache.druid.java.util.common.IAE; +import org.apache.druid.java.util.common.logger.Logger; +import org.apache.druid.server.security.Access; +import org.apache.druid.server.security.Action; +import org.apache.druid.server.security.AuthenticationResult; +import org.apache.druid.server.security.Authorizer; +import org.apache.druid.server.security.Resource; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.security.UserGroupInformation; +import org.apache.ranger.plugin.audit.RangerDefaultAuditHandler; +import org.apache.ranger.plugin.policyengine.RangerAccessRequestImpl; +import org.apache.ranger.plugin.policyengine.RangerAccessResourceImpl; +import org.apache.ranger.plugin.policyengine.RangerAccessResult; +import org.apache.ranger.plugin.service.RangerBasePlugin; + +import java.io.IOException; +import java.net.URL; +import java.util.Arrays; +import java.util.Date; +import java.util.HashSet; +import java.util.Locale; +import java.util.Set; + +@JsonTypeName("ranger") +public class RangerAuthorizer implements Authorizer +{ + private static final Logger LOG = new Logger(RangerAuthorizer.class); + + public static final String RANGER_DRUID_SERVICETYPE = "druid"; + public static final String RANGER_DRUID_APPID = "druid"; + + public static final String RANGER_DRUID_DEFAULT_HADOOP_CONF = "druid-ranger-site.xml"; + + private RangerBasePlugin rangerPlugin; + private boolean useUgi; + + @JsonCreator + public RangerAuthorizer( + @JsonProperty("keytab") String keytab, + @JsonProperty("principal") String principal, + @JsonProperty("use_ugi") boolean useUgi, + @JsonProperty("hadoop_config") String hadoopConfig) + { + Configuration configuration = new Configuration(); + + this.useUgi = useUgi; + + if (hadoopConfig != null) { + URL url = configuration.getResource(hadoopConfig); + if (url == null) { + LOG.warn("Hadoop config " + hadoopConfig + " not found"); Review comment: ```suggestion LOG.warn("Hadoop config %s not found", hadoopConfig); ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
