ccaominh commented on a change in pull request #9614: Add tests for valid and
invalid datasource names
URL: https://github.com/apache/druid/pull/9614#discussion_r403344786
##########
File path:
server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java
##########
@@ -54,10 +56,20 @@
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import java.util.Collections;
+import java.util.List;
import java.util.Map;
public class DataSchemaTest
{
+
+ private static final String VALID_DATASOURCE_CHARS_NAME =
"alpha123..*~!@#&%^&*()-+ Россия\\ 한국 中国!";
+ private static final String VALID_DATASOURCE_CHARS_FOR_SERIALIZER =
"alpha123..*~!@#&%^&*()-+ Россия\\\\ 한국 中国!";
Review comment:
Suggest adding a helper method that escapes `VALID_DATASOURCE_CHARS_NAME`.
The helper method can be used here as well as in
`testSerializeWithInvalidDataSourceName()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
