clintropolis commented on a change in pull request #9614: Add tests for valid and invalid datasource names URL: https://github.com/apache/druid/pull/9614#discussion_r404438984
########## File path: server/src/test/java/org/apache/druid/segment/indexing/DataSchemaTest.java ########## @@ -54,10 +57,14 @@ import java.nio.charset.StandardCharsets; import java.util.Arrays; import java.util.Collections; +import java.util.List; import java.util.Map; -public class DataSchemaTest +public class DataSchemaTest extends NullHandlingTest Review comment: nit: it's actually `InitializedNullHandlingTest` that you want, but the one you've extended also initializes null handling ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
