clintropolis opened a new pull request #9731: URL: https://github.com/apache/druid/pull/9731
### Description This PR changes `ColumnCapabilites.hasMultipleValues()` to be a `Capable` enum added in #9662, and removes `ColumnCapabilities.isComplete()` which was added in #7588, along with some slight refactoring of `ColumnCapabilitiesImpl`, to remove the `merge` method, which was only setting `isComplete`, and replacing it with a static method `ColumnCapabilities.complete` which is used at index merger time to finalize `Capable.UNKNOWN` values. Many uses in the query path of `ColumnCapabilites.hasMultipleValues` use a new `Capable` method, `isMaybeTrue` to check for either `TRUE` or `UNKNOWN`. <hr> This PR has: - [ ] been self-reviewed. - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. <hr> ##### Key changed/added classes in this PR * `ColumnCapabilities` * `ColumnCapabilitiesImpl` * a bunch of query and ingestion path stuffs that deals with strings having multiple values or not ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
