clintropolis commented on a change in pull request #9731:
URL: https://github.com/apache/druid/pull/9731#discussion_r435528807
##########
File path:
processing/src/main/java/org/apache/druid/segment/DimensionHandlerUtils.java
##########
@@ -60,7 +60,8 @@
.setDictionaryEncoded(false)
.setDictionaryValuesUnique(false)
.setDictionaryValuesSorted(false)
- .setHasBitmapIndexes(false);
+ .setHasBitmapIndexes(false)
+ .setHasMultipleValues(false);
Review comment:
The issue with this is that it is used when column capabilities don't
exist by `getEffectiveCapabilities`, and `makeVectorProcessor` was not in fact
checking if it was `complete`, so the other change in this file to check
`isMaybeTrue` causes a ton of test failures because it now it tries to make
multi-value dimension processors/selectors for these columns. We could leave it
as unknown, but change `makeVectorProcessor` to `isTrue`, but that doesn't seem
correct either. Ideally, we remove these default capabilities entirely, but we
aren't quite there yet I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
