ccaominh commented on a change in pull request #9807:
URL: https://github.com/apache/druid/pull/9807#discussion_r419005812
##########
File path:
extensions-core/kinesis-indexing-service/src/test/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisorTest.java
##########
@@ -1839,6 +1857,198 @@ public void
testDiscoverExistingPublishingAndReadingTask() throws Exception
), publishingReport.getCurrentOffsets());
}
+ @Test
+ public void
testDiscoverExistingPublishingAndReadingTaskWithoutTimeLagMetrics() throws
Exception
+ {
+ // Like testDiscoverExistingPublishingAndReadingTask, but with time lag
metrics disabled
Review comment:
Perhaps refactor this into helper method that also used by
`testDiscoverExistingPublishingAndReadingTask`, since it looks like the only
differences are (1) whether time lag metrics are enabled/disabled in the
supervisor spec and (2) the assert for the proper lag metric value in the
active report.
##########
File path:
extensions-core/kinesis-indexing-service/src/test/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisorTest.java
##########
@@ -3824,6 +4035,100 @@ public void testIsTaskCurrent()
verifyAll();
}
+ @Test
+ public void testTimeLagMetricsDisabled() throws Exception
Review comment:
With regards to disabling the time lag metric, what behavior is tested
by `testDiscoverExistingPublishingAndReadingTaskWithoutTimeLagMetrics` that is
not covered by this test?
What do you think about refactoring some of the logic here so that it's
reused by `testNoInitialState`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
