jon-wei commented on a change in pull request #9807:
URL: https://github.com/apache/druid/pull/9807#discussion_r419035427
##########
File path:
extensions-core/kinesis-indexing-service/src/test/java/org/apache/druid/indexing/kinesis/supervisor/KinesisSupervisorTest.java
##########
@@ -3824,6 +4035,100 @@ public void testIsTaskCurrent()
verifyAll();
}
+ @Test
+ public void testTimeLagMetricsDisabled() throws Exception
Review comment:
`testDiscoverExistingPublishingAndReadingTaskWithoutTimeLagMetrics` was
checking for time lag metrics in the active tasks portion of the supervisor
status report, which `testNoInitialState` didn't do.
`testNoInitialState` had checks for time lag metrics in the aggregate-level
portion of the supervisor report which
`testDiscoverExistingPublishingAndReadingTaskWithoutTimeLagMetrics` didn't
I ended up deleting `testTimeLagMetricsDisabled` and collapsed the time lag
metrics tests into `testDiscoverExistingPublishingAndReadingTask*` test pair
which now checks all 3 areas.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
