jihoonson commented on a change in pull request #9804:
URL: https://github.com/apache/druid/pull/9804#discussion_r420433164
##########
File path: docs/development/extensions-core/lookups-cached-global.md
##########
@@ -208,12 +208,12 @@ The remapping values for each globally cached lookup can
be specified by a JSON
|Property|Description|Required|Default|
|--------|-----------|--------|-------|
|`pollPeriod`|Period between polling for updates|No|0 (only once)|
-|`uri`|URI for the file of interest|No|Use `uriPrefix`|
-|`uriPrefix`|A URI which specifies a directory (or other searchable resource)
in which to search for files|No|Use `uri`|
+|`uri`|URI for the file of interest, specified as a file, hdfs, or s3
path|No|Use `uriPrefix`|
+|`uriPrefix`|A URI that specifies a directory (or other searchable resource)
in which to search for files|No|Use `uri`|
|`fileRegex`|Optional regex for matching the file name under `uriPrefix`. Only
used if `uriPrefix` is used|No|`".*"`|
|`namespaceParseSpec`|How to interpret the data at the URI|Yes||
-One of either `uri` xor `uriPrefix` must be specified.
+One of either `uri` or `uriPrefix` must be specified, as either a local file
system (file://), HDFS (hdfs://), or S3 (s3://) location. HTTP location are not
currently supported.
Review comment:
`location are` -> `location is`?
##########
File path: docs/operations/basic-cluster-tuning.md
##########
@@ -407,15 +407,15 @@ Enabling process termination on out-of-memory errors is
useful as well, since th
-XX:+ExitOnOutOfMemoryError
-XX:+HeapDumpOnOutOfMemoryError
-XX:HeapDumpPath=/var/logs/druid/historical.hprof
--XX:MaxDirectMemorySize=10240g
+-XX:MaxDirectMemorySize=1g
Review comment:
Nice
##########
File path: docs/development/extensions-core/kafka-ingestion.md
##########
@@ -122,9 +122,9 @@ A sample supervisor spec is shown below:
|Field|Description|Required|
|--------|-----------|---------|
|`type`|The supervisor type, this should always be `kafka`.|yes|
-|`dataSchema`|The schema that will be used by the Kafka indexing task during
ingestion, see [`dataSchema`](../../ingestion/index.md#dataschema) for
details.|yes|
-|`ioConfig`|A KafkaSupervisorIOConfig to configure the supervisor and indexing
tasks, see below.|yes|
-|`tuningConfig`|A KafkaSupervisorTuningConfig to configure the supervisor and
indexing tasks, see below.|no|
+|`dataSchema`|The schema that will be used by the Kafka indexing task during
ingestion. See [`dataSchema`](../../ingestion/index.md#dataschema) for
details.|yes|
+|`tuningConfig`|A KafkaSupervisorTuningConfig object for configuring
performance-related settings for the supervisor and indexing tasks. See
[KafkaSupervisorTuningConfig](#kafkasupervisortuningconfig) below.|no|
+|`ioConfig`|A KafkaSupervisorIOConfig object for configuring Kafka connection
and I/O-related settings for the supervisor and indexing task. See
[KafkaSupervisorIOConfig](#kafkasupervisorioconfig) below.|yes|
Review comment:
Hmm, I've been curious whether it's better to show `ioConfig` before
`tuningConfig` since `ioConfig` is mandatory while `tuningConfig` is optional.
Is it better to switch their order in other places?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
