suneet-s opened a new pull request #9830: URL: https://github.com/apache/druid/pull/9830
### Description This change validates an assumption made HashJoinSegmentStorageAdapter. It was assumed that the filter used during join filter pre-analysis is the same as the filter passed to the HashJoinSegmentStorageAdapter to make a cursor. As pointed out in #9792, this is not always the case. This change makes it so that any query that violates this assumption fails rather than showing incorrect results. The issue is surfaced when nested groupby queries operate on a non-table datasource. This is because the GroupByQueryQueryToolChest has optimizations built in to it that pushes down the filters from the outer group by to the inner query when making the cursor. So the pre-join analysis is invalid. The result of this bug is that as of 0.18 filters in the outer groupBy are ignored. This PR fails the query rather than providing the user with invalid results. A follow up PR is needed to address #9792 so that the query executes correctly. This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths. - [x] added integration tests. - [x] been tested in a test Druid cluster. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
