gianm edited a comment on pull request #9830: URL: https://github.com/apache/druid/pull/9830#issuecomment-624730282
@suneet-s it looks like some tests are failing because Filter.equals is not always implemented. IIRC, nothing depended on that being implemented prior to this patch. > The result of this bug is that as of 0.18 filters in the outer groupBy are ignored. AFAICT the queries affected are groupBy stacks where the inner query is on a join datasource whose base datasource is not a table. (Join because the bug is in the join filter preanalysis code; not-a-table because it gets triggered when filter preanalysis is done based on the wrong stacked query, but Historicals don't see stacked queries, so if it's a table this wouldn't happen.) So we should add a test for this case. You couldn't do these kinds of queries at all prior to 0.18. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
