ccaominh opened a new pull request #9863:
URL: https://github.com/apache/druid/pull/9863


   ### Description
   
   Add an automated way of checking if new code has adequate unit tests, since 
merging code coverage reports and check coverage thresholds via coveralls or 
codecov is unreliable.
   
   The following minimum unit test code coverage is now enforced on new code:
   - 80% functions
   - 65% branch
   - 65% line
   
   Branch and line coverage thresholds are slightly lower for now as they are 
harder to achieve.
   
   After the code coverage check looks reliable, the thresholds can be 
increased later if needed.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] been manually tested: https://github.com/ccaominh/druid/pull/1
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to