agricenko commented on a change in pull request #9854:
URL: https://github.com/apache/druid/pull/9854#discussion_r425718065
##########
File path: integration-tests/docker/docker-compose.base.yml
##########
@@ -0,0 +1,271 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
yes it's possible, we can create file with env variables, but then this
docker-compose file will be bad readable.
What is the reason to use variable like: "COMMON_ENV"?
Env variables used in case if you want to customize something
------- Currently -------
This part is readable, you can understand that we mount file
"zookeeper.conf" from "current dir/service-supervisords/zookeeper.conf" to some
path in your container and you can see this path
volumes:
- ${HOME}/shared:/shared
-
./service-supervisords/zookeeper.conf:/usr/lib/druid/conf/zookeeper.conf
- ./service-supervisords/kafka.conf:/usr/lib/druid/conf/kafka.conf
------- With env variables like in run_cluster.sh -------
look at this configuration from person who is new. What he see? He see a lot
of env variables, he don't know what the values of this variables, he need to
spend some time to find where this variables declared to see path. This
configuration is hard to understand
volumes:
- ${HOME}/shared:/shared
-
${SERVICE_SUPERVISORDS_DIR}/zookeeper.conf:${SUPERVISORDIR}/zookeeper.conf
- ${SERVICE_SUPERVISORDS_DIR}/kafka.conf:${SUPERVISORDIR}/kafka.conf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
