agricenko commented on a change in pull request #9854:
URL: https://github.com/apache/druid/pull/9854#discussion_r425742976
##########
File path: integration-tests/docker/docker-compose.base.yml
##########
@@ -0,0 +1,271 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
you need to split "env variables for customizing server" and "env
variables that you created for development".
We need to avoid "env variable for development" in docker-compose files.
If you have some configuration for your continer this config files must be
in close folder.
If you want to move docker compose files you need to move then with
configuration files. they need to be in the same folder because they have the
same context
Folders paths, configs paths, any other things that related to container
config they must be in "docker-compose" files, not in shell scripts, java
pom.xml, etc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
