agricenko commented on a change in pull request #9854:
URL: https://github.com/apache/druid/pull/9854#discussion_r425762911
##########
File path: integration-tests/docker/docker-compose.test-env.yml
##########
@@ -0,0 +1,173 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
Review comment:
1. I expect to use "docker-compose.yml" for all tests that do not need
custom env configs
But unfortunately this is not works, because druid.sh prepare data for
"query" and "security" tests (this is wrong because this must be done by tests)
I think that we can remove "docker-compose.test-env.yml"
I move DRUID_INTEGRATION_TEST_GROUP to docker-compose.yml
2. docker-compose - it's files for containers, not for tests. If your tests
need "DRUID_INTEGRATION_TEST_GROUP" variable you pass this variable my maven
run or by some config file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
