FrankChen021 commented on pull request #9919: URL: https://github.com/apache/druid/pull/9919#issuecomment-635379582
> I'm not familiar with DBI's SQLLog, but I have some concerns with the overall approach. Why not just use the provided SLF4JLog? By default the provided level is trace `SLF4JLog` was adopted in my first commit 169013a. The reason I discarded it is because `SLF4JLog` not only outputs the sql and its execution time but also outputs all operation events, such as transaction opened, DBI handle obtained/released. When I ran that build to test, I saw too many these logs which overwhelmed the sql log and distracted me from the core logs I wanted to get. > > As a druid operator - is there a way for me to override the implementation of the SQLLog? Or do I need to make a custom build of Druid. Sorry, I didn't get your question. Do you mean if we should allow others to implement another version of SQLLog to replace the one provided by this PR? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
