suneet-s commented on pull request #9919: URL: https://github.com/apache/druid/pull/9919#issuecomment-635430414
> Hi @suneet-s, as suggested by @yuanlihan in the issue, it's better to emit the sql and execution time through metrics along with logging. After consideration and review, to support emitter in the next step, it's BETTER to implement logging/metrics through `TimingCollector` interface provided by DBI instead of `SQLLog`. I will make a change to the code later Sounds good. I'll wait for the new patch and review then. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
