gianm commented on a change in pull request #9731:
URL: https://github.com/apache/druid/pull/9731#discussion_r435669232
##########
File path:
processing/src/main/java/org/apache/druid/segment/ColumnSelectorBitmapIndexSelector.java
##########
@@ -157,14 +158,16 @@ public void close() throws IOException
}
@Override
- public boolean hasMultipleValues(final String dimension)
+ public ColumnCapabilities.Capable hasMultipleValues(final String dimension)
{
if (isVirtualColumn(dimension)) {
return
virtualColumns.getVirtualColumn(dimension).capabilities(dimension).hasMultipleValues();
}
final ColumnHolder columnHolder = index.getColumnHolder(dimension);
- return columnHolder != null &&
columnHolder.getCapabilities().hasMultipleValues();
+ return columnHolder != null
+ ? columnHolder.getCapabilities().hasMultipleValues()
+ : ColumnCapabilities.Capable.UNKNOWN;
Review comment:
I think the code you have is correct, but it's not going to do the
optimized path (return `supportsBitmapIndex = true`) for a missing column, even
though it would be okay to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
