gianm commented on a change in pull request #9731:
URL: https://github.com/apache/druid/pull/9731#discussion_r435575043
##########
File path:
processing/src/main/java/org/apache/druid/segment/ColumnSelectorBitmapIndexSelector.java
##########
@@ -160,11 +160,11 @@ public void close() throws IOException
public boolean hasMultipleValues(final String dimension)
Review comment:
IMO, it's ok to return a Capable without it being a standalone class.
Like, calling it `ColumnCapabilities.Capable` isn't that weird and is ok I
think.
Another alternative is to clarify the behavior of the function through
javadocs and, perhaps, changing its name to be more explicit about what it does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
