suneet-s commented on pull request #9690: URL: https://github.com/apache/druid/pull/9690#issuecomment-641482835
It looks like CI is complaining about missing tests ``` Diff coverage statistics: ------------------------------------------------------------------------------ | lines | branches | functions | path ------------------------------------------------------------------------------ | 100% (1/1) | 100% (0/0) | 100% (1/1) | org/apache/druid/emitter/dropwizard/DropwizardEmitterModule.java | 0% (0/1) | 100% (0/0) | 0% (0/1) | org/apache/druid/emitter/graphite/GraphiteEmitterModule.java | 0% (0/1) | 100% (0/0) | 0% (0/1) | org/apache/druid/emitter/influxdb/InfluxdbEmitterModule.java | 0% (0/1) | 100% (0/0) | 0% (0/1) | org/apache/druid/emitter/kafka/KafkaEmitterModule.java | 0% (0/1) | 100% (0/0) | 0% (0/1) | org/apache/druid/emitter/opentsdb/OpentsdbEmitterModule.java | 0% (0/1) | 100% (0/0) | 0% (0/1) | org/apache/druid/emitter/statsd/StatsDEmitterModule.java ------------------------------------------------------------------------------ ``` @alex-plekhanov I know this isn't part of your change, but would it be easy to add a unit test for these modules that verifies `getJacksonModules` is empty so that CI is happy ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
