clintropolis commented on a change in pull request #10020:
URL: https://github.com/apache/druid/pull/10020#discussion_r439689535
##########
File path: processing/src/main/java/org/apache/druid/query/DataSource.java
##########
@@ -35,7 +35,8 @@
@JsonSubTypes.Type(value = UnionDataSource.class, name = "union"),
@JsonSubTypes.Type(value = JoinDataSource.class, name = "join"),
@JsonSubTypes.Type(value = LookupDataSource.class, name = "lookup"),
- @JsonSubTypes.Type(value = InlineDataSource.class, name = "inline")
+ @JsonSubTypes.Type(value = InlineDataSource.class, name = "inline"),
+ @JsonSubTypes.Type(value = GlobalTableDataSource.class, name = "global")
Review comment:
I'm not sure if it makes sense to add yet until more of #9953 is
implemented since making effective use of this requires `GlobalTableDataSource`
to be bound to a `JoinableFactory`, otherwise it behaves the same as
`TableDataSource`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
