clintropolis opened a new pull request #10020:
URL: https://github.com/apache/druid/pull/10020
### Description
Related to #9953, this PR adds a `GlobalTableDataSource` (better name
suggestions welcome) and injects `SegmentManager` into `DruidSchema`, which
will now also poll the set of datasources for which the broker loads segments
to construct the `DruidTable` with a `GlobalTableDataSource`.
`GlobalTableDataSource` extends `TableDataSource`, but sets `isGlobal` to
true, and `isCacheable` to false, though it might actually be cacheable...
still need to think about that. Direct queries to these segments will be
performed on historicals as being a `TableDataSource` it will fail the checks
to run locally on the broker, but if wired up to a `JoinableFactory` that
supplies an `IndexedTable`, can be used as part of a join clause and be run
directly with the query instead of requiring a subquery join with an
`InlineDatasource`
Marking WIP because this still needs tests.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
<hr>
##### Key changed/added classes in this PR
* `DruidSchema`
* `GlobalTableDataSource`
* `TheirBaz`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
