maytasm commented on a change in pull request #9965:
URL: https://github.com/apache/druid/pull/9965#discussion_r439701586
##########
File path:
server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java
##########
@@ -391,6 +396,123 @@ public Response getServedSegmentsInInterval(
return getServedSegmentsInInterval(dataSourceName, full != null,
theInterval::contains);
}
+ @GET
+ @Path("/{dataSourceName}/loadstatus")
+ @Produces(MediaType.APPLICATION_JSON)
+ @ResourceFilters(DatasourceResourceFilter.class)
+ public Response getDatasourceLoadstatus(
+ @PathParam("dataSourceName") String dataSourceName,
+ @QueryParam("interval") @Nullable final String interval,
+ @QueryParam("forceMetadataRefresh") @Nullable final Boolean
forceMetadataRefresh,
+ @QueryParam("simple") @Nullable final String simple,
+ @QueryParam("full") @Nullable final String full
+ )
+ {
+ final Interval theInterval;
+ if (interval == null) {
+ long defaultIntervalOffset = 14 * 24 * 60 * 60 * 1000;
+ long currentTimeInMs = System.currentTimeMillis();
+ theInterval = Intervals.utc(currentTimeInMs - defaultIntervalOffset,
currentTimeInMs);
+ } else {
+ theInterval = Intervals.of(interval.replace('_', '/'));
+ }
+
+ boolean requiresMetadataStorePoll = forceMetadataRefresh == null ? true :
forceMetadataRefresh;
Review comment:
The reason I have the default as true is to prevent operator mistake by
forgetting to set to true on the first call. Basically, you will get the
correct result if you make every call with true. However, you will not get the
correct result (and can be making query when segments are not yet loaded!) if
you make every call with false. Hence, having default to true to a safer option
imo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
