maytasm commented on pull request #9965: URL: https://github.com/apache/druid/pull/9965#issuecomment-643567018
> The doc looks basically good. I've added some suggestions, but all minor rewording issues. > > One thought, did you consider putting this content lower on the page, with the other datasource APIs? Then you'd get the interval explanation in that section with it. It now comes after the cluster-wide segment loading API section, which has that advantage, but you could always link from there to the new datasource segment loading section. In fact, maybe the existing https://druid.apache.org/docs/latest/operations/api-reference.html#segment-loading section should be renamed to "Segment loading by cluster". I think it is better to keep this API with the Segment Loading section. This is because... 1) The person using this API is probably more interested in knowing if segments have been loaded or not rather than the metadata information of the datasource. 2) The response of this API contains no information related to the metadata information of the datasource at all. The response only contains information regarding the progress of the segment loading. 3) The interval explanation does not apply to this API. The interval explanation in the datasource APIs section is regarding interval in the URI path. Here, the interval is use as a query param. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
