clintropolis commented on a change in pull request #10033:
URL: https://github.com/apache/druid/pull/10033#discussion_r444696192
##########
File path:
core/src/test/java/org/apache/druid/timeline/partition/HashBasedNumberedPartialShardSpecTest.java
##########
@@ -73,5 +73,21 @@ public void testJsonPropertyNames() throws IOException
Assert.assertEquals(expected.getPartitionDimensions(),
map.get("partitionDimensions"));
Assert.assertEquals(expected.getBucketId(), map.get("bucketId"));
Assert.assertEquals(expected.getNumBuckets(), map.get("numPartitions"));
+ Assert.assertEquals(expected.getBucketId(), map.get("bucketId"));
+ }
+
+ @Test
+ public void testComplete()
+ {
+ final HashBasedNumberedPartialShardSpec partialShardSpec = new
HashBasedNumberedPartialShardSpec(
+ ImmutableList.of("dim"),
+ 2,
+ 4
+ );
+ final ShardSpec shardSpec = partialShardSpec.complete(new ObjectMapper(),
1, 3);
Review comment:
just curious, this doesn't need to change, why does this test use `new
ObjectMapper()` instead of `MAPPER`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
