maytasm commented on a change in pull request #10033:
URL: https://github.com/apache/druid/pull/10033#discussion_r445218905
##########
File path: core/src/main/java/org/apache/druid/timeline/partition/ShardSpec.java
##########
@@ -125,8 +125,13 @@ default short getAtomicUpdateGroupSize()
boolean possibleInDomain(Map<String, RangeSet<String>> domain);
/**
- * Returns true if two segments of this and other shardSpecs can exist in
the same time chunk.
+ * Returns true if this shardSpec and the given {@link PartialShardSpec}
share the same partition space.
+ * Any implementation of {@link OverwriteShardSpec} should return true.
+ *
+ * @see PartitionIds
*/
- @JsonIgnore
- boolean isCompatible(Class<? extends ShardSpec> other);
+ default boolean sharePartitionSpace(PartialShardSpec partialShardSpec)
+ {
+ return !partialShardSpec.useNonRootGenerationPartitionSpace();
Review comment:
Seems like the java doc for ShardSpec#sharePartitionSpace and
OverwriteShardSpec#sharePartitionSpace should be updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
