suneet-s commented on a change in pull request #10093:
URL: https://github.com/apache/druid/pull/10093#discussion_r447137245
##########
File path:
processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java
##########
@@ -524,6 +524,7 @@ public boolean isCacheable(GroupByQuery query, boolean
willMergeRunners)
.appendCacheables(query.getAggregatorSpecs())
.appendCacheables(query.getDimensions())
.appendCacheable(query.getVirtualColumns())
+ .appendCacheable(query.getLimitSpec())
Review comment:
Does this also need to consider the `havingSpec` similar to the
ResultLevelCacheKey below?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
