jihoonson commented on pull request #10082:
URL: https://github.com/apache/druid/pull/10082#issuecomment-652097170
The test coverage check now complains about these classes:
```
------------------------------------------------------------------------------
| lines | branches | functions | path
------------------------------------------------------------------------------
| 33% (1/3) | 0% (0/2) | 83% (10/12) |
org/apache/druid/query/Query.java
| 100% (3/3) | 100% (0/0) | 100% (6/6) |
org/apache/druid/query/UnionQueryRunner.java
| 46% (19/41) | 36% (8/22) | 61% (19/31) |
org/apache/druid/query/Druids.java
| 100% (6/6) | 100% (2/2) | 100% (3/3) |
org/apache/druid/query/context/ResponseContext.java
| 16% (1/6) | 0% (0/2) | 70% (7/10) |
org/apache/druid/query/topn/TopNQueryBuilder.java
| 33% (2/6) | 0% (0/2) | 33% (1/3) |
org/apache/druid/query/groupby/GroupByQuery.java
------------------------------------------------------------------------------
Total diff coverage:
- lines: 49% (32/65)
- branches: 33% (10/30)
- functions: 70% (46/65)
ERROR: Insufficient line coverage of 49% (32/65). Required 50%.
ERROR: Insufficient branch coverage of 33% (10/30). Required 50%.
```
`Druids`, `TopNQueryBuilder`, and `GroupByQuery.Builder` are for query
builders which are used only in unit tests, so I suppressed the check for them.
For `Query`, it's about the new default `getMostSpecificId` method which I
don't expect any class will override it unless some query type has its own ID
system. I think we can ignore it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
