gianm commented on a change in pull request #10082:
URL: https://github.com/apache/druid/pull/10082#discussion_r448525940
##########
File path:
processing/src/main/java/org/apache/druid/query/QueryInterruptedException.java
##########
@@ -105,6 +106,8 @@ private static String getErrorCodeFromThrowable(Throwable e)
return RESOURCE_LIMIT_EXCEEDED;
} else if (e instanceof UnsupportedOperationException) {
return UNSUPPORTED_OPERATION;
+ } else if (e instanceof TruncatedResponseContextException) {
+ return TRUNCATED_RESPONSE_CONTEXT;
Review comment:
This should be added to the documentation (all of these error codes are
spelled out in a table in `querying/querying.md`).
##########
File path: processing/src/main/java/org/apache/druid/query/QueryContexts.java
##########
@@ -344,6 +346,19 @@ public String toString()
return defaultTimeout;
}
+ public static <T> Query<T> setFailOnTruncatedResponseContext(Query<T> query)
Review comment:
Should be `withFailOnTruncatedResponseContext`, not
`setFailOnTruncatedResponseContext`, because nothing's being set (a modified
copy is being returned).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
