gianm commented on pull request #10082: URL: https://github.com/apache/druid/pull/10082#issuecomment-652576873
> @gianm thanks for the review. As Travis is extremely slow recently, I'd like to address your last comments in a follow-up with doc for the known issue with response context not shared by subqueries. That works for me. I think the follow-ups we'd want before the next release would be: 1. Add integration tests. 2. Add the new error code to the documentation: https://github.com/apache/druid/pull/10082#discussion_r448525940 3. Modify this method name: https://github.com/apache/druid/pull/10082#discussion_r448526783 For documenting the limitations of response context, I'm actually not sure what we should do, because I realized that currently they aren't documented at all. They are a secret feature, I suppose. So I don't think there's any need to document their limitations if we aren't including it as a documented feature in the first place. I think there are two good options here: - Do nothing, don't add any docs. - Document response contexts as an 'alpha' or 'beta' level feature, and include documentation about their limitations (they can be too long and will either truncate or fail the query; and they aren't currently collected from all subqueries). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
