jihoonson commented on a change in pull request #10203:
URL: https://github.com/apache/druid/pull/10203#discussion_r459856645
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/overlord/config/RemoteTaskRunnerConfig.java
##########
@@ -81,15 +83,14 @@ public Period getTaskCleanupTimeout()
public int getMaxZnodeBytes()
{
- return maxZnodeBytes;
+ return (int) maxZnodeBytes.getValue();
Review comment:
This wouldn't cause integer overflow because the max is limited as
`Integer.MAX_VALUE`, but this seems fragile and easy to make a mistake. How
about adding `asInt()` which has a check for integer overflow?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
