FrankChen021 commented on a change in pull request #10203:
URL: https://github.com/apache/druid/pull/10203#discussion_r460709226
##########
File path:
processing/src/main/java/org/apache/druid/query/DruidProcessingConfig.java
##########
@@ -40,9 +41,14 @@
private AtomicReference<Integer> computedBufferSizeBytes = new
AtomicReference<>();
@Config({"druid.computation.buffer.size", "${base_path}.buffer.sizeBytes"})
+ public String bufferSizeConfigured()
+ {
+ return "-1";
+ }
+
public int intermediateComputeSizeBytesConfigured()
{
- return DEFAULT_PROCESSING_BUFFER_SIZE_BYTES;
+ return (int) Bytes.parse(bufferSizeConfigured(),
DEFAULT_PROCESSING_BUFFER_SIZE_BYTES);
Review comment:
Yes, it should return an instance of `Bytes`. I didn't understand how
`@Config` works at first, so `String` was used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
