josephglanville commented on pull request #10232: URL: https://github.com/apache/druid/pull/10232#issuecomment-668917061
And yes `Obj` vs `Obj1` is my bad. I added the 1 without properly testing based on a quick read of the spec while adding comments. Arguably we should parse the following byte as uint8 to determine the OCF format version but probably overkill. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
