josephglanville commented on pull request #10232: URL: https://github.com/apache/druid/pull/10232#issuecomment-680069502
@gianm @vogievetsky added the docs regarding the type handling and made the change to check the Avro OCF version byte. Additionally I added some tests that ensure we don't regress on the sampler API by ensuring output from `sample()` is properly serialisable to JSON. Though I think more can be done to make this better I think this should probably be merged to unbreak Avro support in the Web UI for now. I intend to submit some further changes to support Avro Unions so if you have additional things you want changed in the Avro support I can look into it as part of that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
