clintropolis commented on a change in pull request #10248:
URL: https://github.com/apache/druid/pull/10248#discussion_r467351470
##########
File path:
processing/src/test/java/org/apache/druid/segment/IndexMergerTestBase.java
##########
@@ -2012,32 +2011,6 @@ public void testDictIdSeeker()
Assert.assertEquals(-1, dictIdSeeker.seek(5));
}
- @Test(expected = IllegalArgumentException.class)
- public void testCloser() throws Exception
Review comment:
2 reasons, first, the mechanism by which it was causing the failure
(artificially setting spatial index) doesn't work anymore since the
capabilities are computed from the indexer rather than stored in a map.
However, looking closer, the test didn't appear to be actually testing what it
says (the closer cleaning up temporary files), because the paths it is checking
for existence do not appear to be created anywhere in the code and only appear
in this test, so removing it entirely didn't seem like a loss.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
