clintropolis commented on a change in pull request #10248:
URL: https://github.com/apache/druid/pull/10248#discussion_r467351559
##########
File path:
processing/src/main/java/org/apache/druid/segment/StringDimensionIndexer.java
##########
@@ -456,6 +471,30 @@ public int getUnsortedEncodedKeyComponentHashCode(int[]
key)
return Arrays.hashCode(key);
}
+ @Override
+ public ColumnCapabilitiesImpl getColumnCapabilities()
+ {
+ ColumnCapabilitiesImpl capabilites = new
ColumnCapabilitiesImpl().setType(ValueType.STRING)
+
.setHasBitmapIndexes(hasBitmapIndexes)
+
.setHasSpatialIndexes(hasSpatialIndexes)
+
.setDictionaryValuesUnique(true)
+
.setDictionaryValuesSorted(false);
+
+ // strings are only single valued, until they are not...
Review comment:
reworked these comments, hopefully it is a bit clearer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
