jon-wei commented on a change in pull request #10278:
URL: https://github.com/apache/druid/pull/10278#discussion_r470383854
##########
File path:
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
##########
@@ -788,18 +785,7 @@ private static void publishSegments(TaskToolbox toolbox,
Map<String, PushedSegme
if (published) {
LOG.info("Published [%d] segments", newSegments.size());
} else {
- LOG.info("Transaction failure while publishing segments, checking if
someone else beat us to it.");
Review comment:
What's the reasoning for removing the more complex logging here? Is it
concern from the segment set being too large?
##########
File path:
server/src/main/java/org/apache/druid/client/indexing/HttpIndexingServiceClient.java
##########
@@ -67,7 +67,8 @@ public HttpIndexingServiceClient(
@Override
public void killUnusedSegments(String dataSource, Interval interval)
{
- runTask(new ClientKillUnusedSegmentsTaskQuery(dataSource, interval));
+ final ClientTaskQuery taskQuery = new
ClientKillUnusedSegmentsTaskQuery(null, dataSource, interval);
+ runTask(taskQuery.getId(), taskQuery);
Review comment:
Do we pull the ID from the `taskQuery` anywhere except here? If not,
maybe we could just pass in the ID here without adding an ID field to the task
query.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
