jon-wei commented on a change in pull request #10278:
URL: https://github.com/apache/druid/pull/10278#discussion_r471827391
##########
File path:
server/src/main/java/org/apache/druid/client/indexing/ClientCompactionTaskQuery.java
##########
@@ -43,14 +42,14 @@
@JsonCreator
public ClientCompactionTaskQuery(
- @JsonProperty("id") @Nullable String id,
+ @JsonProperty("id") String id,
@JsonProperty("dataSource") String dataSource,
@JsonProperty("ioConfig") ClientCompactionIOConfig ioConfig,
@JsonProperty("tuningConfig") ClientCompactionTaskQueryTuningConfig
tuningConfig,
@JsonProperty("context") Map<String, Object> context
)
{
- this.id = id == null ? IdUtils.newTaskId(TYPE, dataSource, null) : id;
+ this.id = Preconditions.checkNotNull(id, "id");
Review comment:
For backwards compatibility, would it be better to allow a null id as
before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
