abhishekagarwal87 commented on a change in pull request #10307:
URL: https://github.com/apache/druid/pull/10307#discussion_r475115873
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/duty/NewestSegmentFirstIterator.java
##########
@@ -247,17 +248,30 @@ public boolean hasNext()
}
}
- private boolean needsCompaction(DataSourceCompactionConfig config,
SegmentsToCompact candidates)
+ @VisibleForTesting
+ static PartitionsSpec
findPartitinosSpecFromConfig(ClientCompactionTaskQueryTuningConfig tuningConfig)
+ {
Review comment:
so if the partition spec is defined in compaction config and is dynamic
partition spec, `MaxRowsPerSegment` is taken from partition spec. if its not
dynamic partition and single dimension for example, then `MaxRowsPerSegment` is
taken from tuning config?
and it the same for `MaxTotalRows`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
