abhishekagarwal87 commented on a change in pull request #10307:
URL: https://github.com/apache/druid/pull/10307#discussion_r475117201
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/duty/NewestSegmentFirstIterator.java
##########
@@ -247,17 +248,30 @@ public boolean hasNext()
}
}
- private boolean needsCompaction(DataSourceCompactionConfig config,
SegmentsToCompact candidates)
+ @VisibleForTesting
+ static PartitionsSpec
findPartitinosSpecFromConfig(ClientCompactionTaskQueryTuningConfig tuningConfig)
+ {
Review comment:
Misread the code. if the maxTotalRows is null in partition spec, should
it be read from tuningConfig instead of using the Long.Max?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
