jihoonson commented on a change in pull request #10308: URL: https://github.com/apache/druid/pull/10308#discussion_r476937485
########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentMergeTaskSuccessReport.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.indexing.common.task.batch.parallel; + +import org.apache.druid.timeline.DataSegment; + +import java.util.Set; + +public class PartialSegmentMergeTaskSuccessReport Review comment: Oops, accidentally included. ########## File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java ########## @@ -160,46 +156,33 @@ private static String makeGroupId(boolean isAppendToExisting, String dataSource) } } - @JsonIgnore private final IndexIngestionSpec ingestionSchema; - @JsonIgnore private IngestionState ingestionState; - @JsonIgnore - private final AuthorizerMapper authorizerMapper; - - @JsonIgnore - private final Optional<ChatHandlerProvider> chatHandlerProvider; + private final CircularBuffer<Throwable> buildSegmentsSavedParseExceptions; - @JsonIgnore - private final RowIngestionMeters determinePartitionsMeters; + private final CircularBuffer<Throwable> determinePartitionsSavedParseExceptions; - @JsonIgnore - private final RowIngestionMeters buildSegmentsMeters; + @MonotonicNonNull Review comment: I think `Nonnull` and `MonotonicNonNull` are different. The [javadoc of `Nonnull` says "The annotated element must not be null. Annotated fields must not be null after construction has completed."](https://www.javadoc.io/doc/com.google.code.findbugs/jsr305/latest/javax/annotation/Nonnull.html), while [the one of `MonotonicNonNull` says "Indicates that once the field (or variable) becomes non-null, it never becomes null again."](https://checkerframework.org/api/org/checkerframework/checker/nullness/qual/MonotonicNonNull.html). For the variables annotated as `MonotonicNonNull` in this class, they are nulls when the class is constructed and initialized later in `runTask()`. Once they are initialized, they never become nulls again until the task is finished. So, I think `MonotonicNonNull` is more proper for these variables. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
