jihoonson opened a new pull request #10308: URL: https://github.com/apache/druid/pull/10308
### Description This is a simple refactoring to have all tools necessary for indexing in `TaskToolbox` rather than having them separately in different classes. This PR also fixes a bug in `PartialSegmentGenerateTask` which [it always creates `DropwizardRowIngestionMeters` instead of using a configured factory](https://github.com/apache/druid/compare/master...jihoonson:toolbox-cleanup?expand=1#diff-89c55f61b470d7633f336aa0b92f8b49L158) (even though `DropwizardRowIngestionMeters` is the only implementation currently). <hr> This PR has: - [x] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. <hr> ##### Key changed/added classes in this PR * `TaskToolbox` * `TaskToolboxFactory` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
