abhishekagarwal87 commented on a change in pull request #10318:
URL: https://github.com/apache/druid/pull/10318#discussion_r477462769
##########
File path: processing/src/main/java/org/apache/druid/query/UnionQueryRunner.java
##########
@@ -41,30 +42,27 @@ public UnionQueryRunner(
public Sequence<T> run(final QueryPlus<T> queryPlus, final ResponseContext
responseContext)
{
Query<T> query = queryPlus.getQuery();
- DataSource dataSource = query.getDataSource();
- if (dataSource instanceof UnionDataSource) {
+
+ final DataSourceAnalysis analysis =
DataSourceAnalysis.forDataSource(query.getDataSource());
+
+ if (analysis.isConcreteTableBased() &&
analysis.getBaseTableDataSources().get().size() != 1) {
Review comment:
In that case, It would also be fine to have a static method
`isUnionDataSource(DataSource)` within `DataSourceAnalysis` class itself that
can be used here as well as in `dataSourceAnalysis.getBaseTableDataSources()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
