gianm commented on a change in pull request #10318:
URL: https://github.com/apache/druid/pull/10318#discussion_r477502295
##########
File path: processing/src/main/java/org/apache/druid/query/UnionQueryRunner.java
##########
@@ -41,30 +42,27 @@ public UnionQueryRunner(
public Sequence<T> run(final QueryPlus<T> queryPlus, final ResponseContext
responseContext)
{
Query<T> query = queryPlus.getQuery();
- DataSource dataSource = query.getDataSource();
- if (dataSource instanceof UnionDataSource) {
+
+ final DataSourceAnalysis analysis =
DataSourceAnalysis.forDataSource(query.getDataSource());
+
+ if (analysis.isConcreteTableBased() &&
analysis.getBaseTableDataSources().get().size() != 1) {
Review comment:
I pushed up a new commit that changes the approach a bit; let me know
what you think. The `getBaseTableDataSources()` concept is gone and replaced by
two separate methods, `getBaseTableDataSource()` and `getBaseUnionDataSource()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
