abhishekagarwal87 commented on a change in pull request #10304: URL: https://github.com/apache/druid/pull/10304#discussion_r478290597
########## File path: extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/ApproximateHistogramVectorAggregator.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.aggregation.histogram; + +import org.apache.druid.query.aggregation.VectorAggregator; +import org.apache.druid.segment.vector.VectorValueSelector; + +import javax.annotation.Nullable; +import java.nio.ByteBuffer; + +public class ApproximateHistogramVectorAggregator implements VectorAggregator +{ + + private final VectorValueSelector selector; + private final ApproximateHistogramBufferAggregatorInternal innerAggregator; + + public ApproximateHistogramVectorAggregator( + VectorValueSelector selector, + int resolution + ) + { + this.selector = selector; + this.innerAggregator = new ApproximateHistogramBufferAggregatorInternal(resolution); + } + + @Override + public void init(final ByteBuffer buf, final int position) + { + innerAggregator.init(buf, position); + } + + @Override + public void aggregate(final ByteBuffer buf, final int position, final int startRow, final int endRow) + { + final boolean[] isValueNull = selector.getNullVector(); + final float[] vector = selector.getFloatVector(); + ApproximateHistogram histogram = innerAggregator.get(buf, position); + + for (int i = startRow; i < endRow; i++) { + if (isValueNull != null && isValueNull[i]) { Review comment: How about if I take `isValueNull != null` out of loop and line L57 becomes boolean hasNulls = isValueNull != null; ``` for (int i = startRow; i < endRow; i++) { if (hasNulls && isValueNull[i]) { ``` This way, I don't need to introduce another predicate in my if condition and number of null checks will still be reduced somewhat. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
