abhishekagarwal87 commented on a change in pull request #10304:
URL: https://github.com/apache/druid/pull/10304#discussion_r478293295
##########
File path:
extensions-core/histogram/src/main/java/org/apache/druid/query/aggregation/histogram/FixedBucketsHistogram.java
##########
@@ -431,6 +433,33 @@ public void incrementMissing()
}
}
+ /**
+ * Merge another datapoint into this one. The other datapoin could be
+ * - base64 encoded string of {@code FixedBucketsHistogram}
+ * - {@code FixedBucketsHistogram} object
+ * - Numeric value
+ *
+ * @param val
+ */
+ void combine(@Nullable Object val)
Review comment:
Good point. I will let this method remain here. Since I am only tackling
numeric values for now, my vector implementation can call `add` directly on
fixed histogram. will make that change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
